Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added struct SRAddOptions and SREditOptions #230

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

shtripat
Copy link
Contributor

@shtripat shtripat commented Sep 28, 2023

Needed to support options while adding/updating site replication

@shtripat shtripat force-pushed the support-replicate-ilm-expiry branch 2 times, most recently from a30c0d4 to 1809a08 Compare September 28, 2023 10:50
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shtripat shtripat marked this pull request as draft September 29, 2023 12:03
@shtripat shtripat force-pushed the support-replicate-ilm-expiry branch 2 times, most recently from b46c74d to 4ce2100 Compare September 29, 2023 12:44
@shtripat shtripat changed the title Added struct SRAddOptions to support options Added struct SRAddOptions and SREditOptions Sep 29, 2023
@shtripat shtripat force-pushed the support-replicate-ilm-expiry branch 2 times, most recently from 335bf82 to 1465cf6 Compare October 9, 2023 11:10
@shtripat shtripat marked this pull request as ready for review October 9, 2023 11:10
@shtripat shtripat requested a review from poornas October 9, 2023 11:10
@shtripat shtripat force-pushed the support-replicate-ilm-expiry branch from 1465cf6 to 348fa99 Compare October 11, 2023 11:44
Needed to support options while adding/updating site replication

Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
@shtripat shtripat force-pushed the support-replicate-ilm-expiry branch from 348fa99 to e3cb014 Compare October 12, 2023 10:03
cluster-commands.go Outdated Show resolved Hide resolved
cluster-commands.go Outdated Show resolved Hide resolved
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
@harshavardhana harshavardhana merged commit 0635979 into minio:main Oct 13, 2023
5 checks passed
anjalshireesh added a commit to anjalshireesh/madmin-go that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants