-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added struct SRAddOptions
and SREditOptions
#230
Merged
harshavardhana
merged 3 commits into
minio:main
from
shtripat:support-replicate-ilm-expiry
Oct 13, 2023
Merged
Added struct SRAddOptions
and SREditOptions
#230
harshavardhana
merged 3 commits into
minio:main
from
shtripat:support-replicate-ilm-expiry
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtripat
force-pushed
the
support-replicate-ilm-expiry
branch
2 times, most recently
from
September 28, 2023 10:50
a30c0d4
to
1809a08
Compare
vadmeste
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shtripat
force-pushed
the
support-replicate-ilm-expiry
branch
2 times, most recently
from
September 29, 2023 12:44
b46c74d
to
4ce2100
Compare
shtripat
changed the title
Added struct
Added struct Sep 29, 2023
SRAddOptions
to support optionsSRAddOptions
and SREditOptions
shtripat
force-pushed
the
support-replicate-ilm-expiry
branch
2 times, most recently
from
October 9, 2023 11:10
335bf82
to
1465cf6
Compare
shtripat
force-pushed
the
support-replicate-ilm-expiry
branch
from
October 11, 2023 11:44
1465cf6
to
348fa99
Compare
Needed to support options while adding/updating site replication Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
shtripat
force-pushed
the
support-replicate-ilm-expiry
branch
from
October 12, 2023 10:03
348fa99
to
e3cb014
Compare
poornas
reviewed
Oct 12, 2023
poornas
reviewed
Oct 12, 2023
poornas
approved these changes
Oct 12, 2023
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
anjalshireesh
added a commit
to anjalshireesh/madmin-go
that referenced
this pull request
Jan 7, 2024
This reverts commit 0635979.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to support options while adding/updating site replication